Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of the PrestaShop project newsletter #1313

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

kpodemski
Copy link
Contributor

Join the PrestaShop Project newsletter! 🚀

Copy link
Contributor

@coffrep coffrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kpodemski many thanks for asking for the review. I added a few changes and also a few comments, great if you can let me know of your thoughts regarding the comments on the blog post. I'm "requesting changes" so you can let me know about the comments, don't hesitate on pinging me on the topic. Great if you can ask for a second review so I can read once again. Thanks a lot!

<div style="padding: 30px 20px; background: #a2e2ef; border: 10px solid white;">
<h2 id="prizes-for-our-newsletter-subscribers">Prizes for Our Newsletter Subscribers! 🏆</h2>

To celebrate the launch, PrestaShop SA is offering 6 exciting prizes* for those who subscribe before the Developer Conference. The prize winners will be announced during the PrestaShop Developer Conference on November 6, 2024. The prizes include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this paragraph I see there is an asterisk * But I do not see where this asterisk takes you, do let me know if I'm missing something @kpodemski thanks a lot!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added asterisk to "Show terms and conditions"

Copy link
Contributor

@coffrep coffrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kpodemski I'm approving, good for publishing! Thanks a lot.

@kpodemski kpodemski merged commit ec88ee2 into PrestaShop:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants