Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product-jsonld.tpl #163

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

gregmag
Copy link

@gregmag gregmag commented Feb 4, 2025

product.condition is an array. Here is product.condition.type the right value to use

Questions Answers
Description? Please be specific when describing this change. What did you change? Why?
Type? bug fix / improvement / new feature / refactor
BC breaks? yes / no
Deprecations? yes / no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Indicate how to verify that this change works as expected.

product.condition is an array. Here is product.condition.type the right value to use
@ps-jarvis
Copy link

Hello @gregmag!

This is your first pull request on classic-theme repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right, but we can simplify it more.

Just use this:

{if !empty($product.condition)}"itemCondition": "{$product.condition.schema_url}",{/if}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

3 participants