refactor(binance): standardize HTTP client usage and improve WebSocke… #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t subscription handling - Replace direct http_client calls with unified public_get method for all public API endpoints - Add comprehensive documentation for WebSocket URL routing by market type in connection manager - Implement automatic time sync and retry mechanism for signed requests with timestamp errors - Enhance rate limiter to handle additional header variations including SAPI endpoints - Refactor WebSocket subscription system to support multiple subscribers per stream - Remove manual MessageRouter spawning in WebSocket constructors for better lifecycle management - Consolidate signed request logic into reusable builder pattern with proper error handling - Optimize futures margin operations using new signed request builder methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t subscription handling