Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Desyncs when shooting with Rocket on high ping #22

Open
PraxTube opened this issue Oct 15, 2023 · 2 comments
Open

BUG: Desyncs when shooting with Rocket on high ping #22

PraxTube opened this issue Oct 15, 2023 · 2 comments

Comments

@PraxTube
Copy link
Owner

When shooting rockets with a high ping (100ms is enough) and spamming Left-Right you will get infinite desyncs that don't reset (even after a rematch). I suspect something with either despawn of rocket, spawn of explosion or something with the timer.
@PraxTube
Copy link
Owner Author

This is an issue of rocket_explosion.rs. More specifically, it's an issue of how we despawn the explosions (currently the issue is the despawn line in animate_rocket_explosions).

PraxTube added a commit that referenced this issue Oct 16, 2023
@PraxTube
restructure!: Use AssetLoader for SpriteSheet
efb7cfc 
The explosion now uses the asset loader to add to the texture atlas. The
`rocket_explosion.rs` also received quite a bit of changes in order to
get rid of the rocket shooting desync, related to #22. The issue is the
despawning in the `animate_rocket_explosions()`, however I didn't fix it
yet. Further debugging is required.
PraxTube added a commit that referenced this issue Oct 16, 2023
@PraxTube
chore: Clean up rocket explosions on clear_map
48f7f15 
This addresses #22 in that the desyncs reset after each round now. The
desyncs are still infinite if you just wait in the round, but at least
they get reset after each round. This really shows that the desyncs are
caused by the explosions not being properly despawned.
@PraxTube
Copy link
Owner Author

PraxTube commented Oct 18, 2023 •
edited
Loading

This might very well be caused by #21. Essentially the Sprite and SpriteSheet don't get rollbed back, and as a result they might live/die unexpectedly.

@PraxTube PraxTube mentioned this issue Oct 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PraxTube