Replace JGit Repository.getRef() with Repository.findRef() #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGit 5.0 (or earlier) deprecated the Repository.getRef(String) method and replaced it with two methods, Repository.findRef(String) and Repository.exactRef(String). JGit 5.2 removed the deprecated method. Git client plugin 3.0 will bundle JGit 5.2 or later. Rather than risk compilation failures when using git client plugin 3.0 and later, switch from the deprecated methods to the new methods.
|
You may also want to push the source code of the latest release to the jenkinsci repository, since it seems to be one release behind the authoritative repository. |
|
I assume someone has already adapted this change into the official repository. Whether they have or not, the release of git client plugin 3.0.0 in the next 1-2 weeks will break the plugin if it has not been updated to include this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JGit 5.0 (or earlier) deprecated the Repository.getRef(String) method and replaced it with two methods, Repository.findRef(String) and Repository.exactRef(String).
JGit 5.2 removed the deprecated method.
Git client plugin 3.0 will bundle JGit 5.2 or later. Rather than risk runtime and compilation failures when using git client plugin 3.0 and later, switch from the deprecated methods to the new methods.
Without this change, this plugin will be broken with the release of git client plugin 3.0.