Switch from hyper to httpx (for Python 3.10 support) #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ES-7755 Simple HTTPX implementation * ES-7755 Add http2 extras to httpx
|
error msg -- KeyError: '{"reason":"MissingProviderToken"}' |
|
@CNKCQ Can you provide some more context? Can you share a code sample of how you're using the library? Does it work with the published version of the package? |
aamaredia
reviewed
Dec 13, 2023
ethanitovitch
approved these changes
Feb 9, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyper is unmaintained and no longer compatible with recent Python releases. This PR switches to the httpx library.
It's based on the work done in this PR, which only added support for certificate-based authentication, and adds support for credentials-based authentication.
I've only tested the credentials-based authentication, with Python 3.10 (not 3.11). I assume the certificate authentication is used by the original author. As mentioned in the other PR, request multiplexing isn't supported by httpx, so it was removed.
The tests has not been updated with the library switch, so they fail.
If this is merged, I suggest squashing the commits.