Research nuget v3 dependency resolution #1836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anam Navied <[email protected]>
Co-authored-by: Anam Navied <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
14 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| { | ||
| List<Dependency> pkgDeps = new(); | ||
|
|
||
| if (dependencyGroupsElement.ValueKind == JsonValueKind.Array) |
There was a problem hiding this comment.
Do we need a else if (tagsElement.ValueKind == JsonValueKind.String)
There was a problem hiding this comment.
I don't think so-- according to https://learn.microsoft.com/en-us/nuget/api/registration-base-url-resource#catalog-entry and https://learn.microsoft.com/en-us/nuget/api/registration-base-url-resource#package-dependency-group both dependencyGroups and dependencies should be an array of objects. Under the first link tags is allowed to be a string or an array.
adityapatwardhan
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Opening this PR to run CI tests for #1778
Note: There is one test that is failing due to a bug that is being tracked here: #1837. The test is temporarily commented out.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.