Modify filter query parameter

[anamnavi]

Modify $filter query parameters IsLatestVersion and IsAbsoluteVersion to be IsLatestVersion eq true or IsAbsoluteVersion eq true for Artifactory to resolve Artifactory issue. For ADO Search() based queries including eq true returns a BadRequest error so it's not included.

Based on the API call Artifactory is performing as supplied here: PowerShell/PowerShellGallery#273 (comment)

the count returns 1 but the response doesn't include a package, however including the eq true actually honors the filter and the response is successful in getting a package from PSGallery (from our testing).

PR Summary

PR Context

Resolves #1656

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[sean-r-williams]

I can confirm that this does mitigate the issue with Artifactory as described in #1656.

My one point of feedback here is that restricting this change to Artifactory might not fully capture the problem/solution at hand.

The "real" bug here is Gallery's poor handling of IsLatestVersion and so on (I think we already aligned on that in the other issues). This shows up in Artifactory because AF proxies NuGet v2 API calls unedited to upstream remotes. However, I don't think Artifactory is the only NuGet provider that does this (in the context of remote NuGet feeds). I provided more context in #1656 (comment).

Some suggestions:

• Adjust the scope of this change from _isJfrogRepo to !_isADORepo - that is, turn it on for any package management provider where it doesn't actively break things
• Add some commentary to indicate that this isn't an Artifactory/JFrog problem, but rather "any PMP that passes queries upstream unedited" (Does Sonatype Nexus have this problem? Are there other PMPs customers use? How do they handle remote-feed proxying?)

[anamnavi]

@sean-r-williams happy new year and my apologies for the late reply. Thank you for the detailed feedback, while I agree that this behavior could happen with other PMPs, our concern is that we don't have enough data on those other ones like Sonatype Nexus to enable this behavior for any PMP that is not ADO, nor test feeds to check if it would break scenarios on those feeds. I'll add a comment saying what Artifactory (and other PMPs) may do and we can come back to it as we get feedback from users using other PMPs.