Archive module preview 2 & 3 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this repo might be missing a change log-- that would be a good thing to add |
|
@SydneyhSmith I added the changelog |
daxian-dbw
reviewed
Aug 11, 2022
CHANGELOG.md
Outdated
Comment on lines
5
to
10
| - Rewrite `Expand-Archive` cmdlet in C# | ||
| - Added `-Format` parameter to `Expand-Archive` | ||
| - Added `-WriteMode` parameter to `Expand-Archive` | ||
| - Added support for zip64 | ||
| - Fixed a bug where the entry names of files in a directory would not be correct when compressing an archive | ||
| - `Compress-Archive` skips writing an entry to an archive if an error occurs while doing so |
There was a problem hiding this comment.
The preview.2 change log has duplicate items from preview.1. Can you please clean them up to only contain the new improvements in preview2?
There was a problem hiding this comment.
@daxian-dbw I updated the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR includes code for the preview 2 release of the Microsoft.PowerShell.Archive v2.0.0 module.
This PR is a rewrite of the Expand-Archive cmdlet in C# (previously, it was written in PowerShell Script). It has support for creating, updating, and overwriting archives. As of now, only zip and zip64 are supported (the .NET APIs for zip and zip64 are the same).
The PR has a -Format parameter which can used to specify the format of the archive. As of now, -Format has only one option: -Format Zip. When additional formats are supported by the module in preview 3, the -Format parameter will be more useful by providing options for tar and compressed tar.
To overwrite the destination path of the archive or items in the archive, use the -WriteMode Overwrite parameter.
For more information regarding behavior of the parameters, please see the RFC #117.
PR Context
To keep the PowerShell/Microsoft.PowerShell.Archive repository up to date with preview 2 code.