Archive module preview 1 PR #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onPath's extension
…estinationPath's extension
…added support for tar, added support for overwrite
…preserved, fixed bug where error and warning messages were not being shown
|
What are the benefits of c# vs ps? |
The main benefit is performance, which has been an issue for the archive module. |
|
Where exactly is the perf problem? I very much doubt that the problem was in PowerShell Engine. |
Mainly compressing and expanding archives would take a long time. Although we are limited by the .NET APIs, rewriting the module in C# reduces overhead. |
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
SteveL-MSFT
reviewed
Aug 2, 2022
|
I'd split the PR on some ones:
|
|
I have to step out soon. I'll try to get through all unresolved conversations. |
…me is not necessarily equal to FileSystemInfo.Name
…r than collecting all paths first
… testing invalid paths
ayousuf23
force-pushed
the
merge-with-master
branch
from
ab55635 to
b5e23c2
Compare
ayousuf23
force-pushed
the
merge-with-master
branch
from
0166791 to
dc557a5
Compare
…e CI status, fixed a bug where a path is determined to be relative to the working directory if the working directory is on a different drive than the path
This was
linked to
issues
Aug 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR includes code for the preview 1 release of the Microsoft.PowerShell.Archive v2.0.0 module.
This PR is a rewrite if the
Compress-Archivecmdlet in C# (previously, it was written in PowerShell Script). It has support for creating, updating, and overwriting archives. As of now, only zip and zip64 are supported (the .NET APIs for zip and zip64 are the same).The PR has support for preserving path structure in relative paths. It also has a
-Formatparameter which can used to specify the format of the archive. As of now,-Formathas only one option:-Format zip. When additional formats are supported by the module in preview 3, the-Formatparameter will be more useful by providing options for tar and compressed tar.An abstraction was created for archives -- the
IArchiveinterface -- so new archive formats can be added to the module easily.To update an archive, use the
-WriteMode Updateparameter. To overwrite an archive, use the-WriteMode Overwriteparameter.For more information regarding behavior of the parameters, please see the RFC #117.
PR Context
To keep the PowerShell/Microsoft.PowerShell.Archive repository up to date with preview 1 code.