-
Notifications
You must be signed in to change notification settings - Fork 43
PSScript resource #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SteveL-MSFT
wants to merge
11
commits into
PowerShell:main
Choose a base branch
from
SteveL-MSFT:psscript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PSScript resource #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gijsreyn
reviewed
Jul 3, 2025
Gijsreyn
reviewed
Jul 3, 2025
theJasonHelmick
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
New PS7 and WinPS5.1 script resources. Allow inline script execution for
get
,set
, andtest
operations.export
isn't supported due to how it works and is reserved for actual resources.If an operation isn't implemented, it is ignored with an
info
level message written and empty JSON being returned. However, iftest
is not implemented, then it always returns that it is_inDesiredState = true
.I did it async to preserve order of traces that could come out of the script. Note that
Write-Information
is mapped totrace
level whileWrite-Verbose
is mapped toinfo
to align with how they are defined in DSC.Separate
Microsoft.DSC.Transitional/PowerShellScript
andMicrosoft.DSC.Transitional/WindowsPowerShellScript
resources (latter is only on Windows) but they use the same underlying script as the resource.Output is expected to not already be JSON and will be converted automatically.
$VerbosePreference
iscontinue
,$DebugPreference
iscontinue
, and$ErrorActionPreference
isstop
.Input can be any valid JSON and is passed to the single parameter declared in the param block as PSCustomObject. If the script has a param and no input is provided, that's an error. If input is provided and the script doesn't have a param, that is also an error. If more than one param is declared, that is also an error.
Example config using it:
PR Context
Fix #885