Fix property discovery on class-based resources WinPS adapter #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveL-MSFT, could you please let me know which of the other PRs goes first? Then I can fix the merge conflict and rewrite some of the logic :) |
SteveL-MSFT
requested changes
Jun 10, 2025
| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
There was a problem hiding this comment.
This indentation doesn't look right?
Ready to go :) |
Gijsreyn
force-pushed
the
fix-class-property-discovery
branch
from
6fc6ecc to
e557557
Compare
Gijsreyn
force-pushed
the
fix-class-property-discovery
branch
from
e557557 to
f0c30dd
Compare
Gijsreyn
force-pushed
the
fix-class-property-discovery
branch
from
f0c30dd to
cdbb4b1
Compare
SteveL-MSFT
requested changes
Jul 2, 2025
| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
Gijsreyn
force-pushed
the
fix-class-property-discovery
branch
from
1af0044 to
b602c8f
Compare
…sreyn/operation-methods into fix-class-property-discovery
SteveL-MSFT
requested changes
Jul 4, 2025
| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
|
Somehow, the OTBS and auto-save do that double indentation. It should be good now. |
SteveL-MSFT
requested changes
Jul 5, 2025
| [System.Management.Automation.Language.ParseError[]] $errors = $null | ||
| $ast = [System.Management.Automation.Language.Parser]::ParseFile($module, [ref]$tokens, [ref]$errors) | ||
| foreach ($e in $errors) { | ||
| $e | Out-String | Write-DscTrace -Operation Error |
There was a problem hiding this comment.
If there are any errors, should we just exit with an exit code?
SteveL-MSFT
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses issue #878. Note: there are no tests and might conflict with PR #877. Depending on these, I have to resolve the conflicts and add relevant tests.
PR Context