Fix config size limit by validating modules in cache #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here you go @SteveL-MSFT. |
SteveL-MSFT
requested changes
Feb 18, 2025
Gijsreyn
force-pushed
the
fix-config-size-limit
branch
from
aa8bf9e to
1ee3537
Compare
SteveL-MSFT
requested changes
Feb 20, 2025
| # check if all the desired modules are in the cache | ||
| $moduleInput | ForEach-Object { | ||
| if ($dscResourceCache.type -notcontains $_) { | ||
| ('ERROR: DSC resource {0} module not found.' -f $_) | Write-DscTrace |
There was a problem hiding this comment.
I realize that other instances in this script have the ERROR: prefix, but this becomes redundant if the trace is of error type since dsc will also add a Error type prefix to the message. Since this is an error, this should be:
Suggested change
| ('ERROR: DSC resource {0} module not found.' -f $_) | Write-DscTrace | |
| ('DSC resource {0} module not found.' -f $_) | Write-DscTrace -Operation Error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses issue #640