Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(i18n) Provide translation strings for Registry #604

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

michaeltlombardi
Copy link
Collaborator

PR Summary

This change replaces static strings in the registry app/lib with translation strings using rust_i18n.

PR Context

@michaeltlombardi michaeltlombardi force-pushed the i18n/main/registry branch 3 times, most recently from 8b0c5d1 to a2e8c2e Compare February 4, 2025 22:40
@SteveL-MSFT
Copy link
Member

@michaeltlombardi can you resolve the merge conflict

@michaeltlombardi
Copy link
Collaborator Author

@SteveL-MSFT - not sure I understand how we're getting this error:

https://github.com/PowerShell/DSC/actions/runs/13246929993/job/37177774845#step:3:1628

Given that earlier in the build we're successfully downloading and compiling v1.2.13 for the treesitter:

https://github.com/PowerShell/DSC/actions/runs/13246929993/job/37177774845#step:3:47

And the failure is happening for pal which this PR doesn't seem to affect.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Feb 18, 2025
Merged via the queue into PowerShell:main with commit d284aaf Feb 18, 2025
4 checks passed
@michaeltlombardi michaeltlombardi deleted the i18n/main/registry branch February 19, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants