Fix tree-sitter not found after cargo install#1431
Open
skabbio1976 wants to merge 1 commit intoPowerShell:mainfrom
Open
Fix tree-sitter not found after cargo install#1431skabbio1976 wants to merge 1 commit intoPowerShell:mainfrom
skabbio1976 wants to merge 1 commit intoPowerShell:mainfrom
Conversation
Install-TreeSitter does not add ~/.cargo/bin to $env:PATH after running cargo install, unlike Install-Rust which does. When Rust is already present on the system (so Install-Rust is a no-op) and ~/.cargo/bin is not in the inherited PATH, the tree-sitter binary cannot be found by Export-GrammarBinding. Add the same PATH update logic that Install-Rust uses. Contact: johan.kallio@teamtech.se
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install-TreeSitterdoes not add~/.cargo/binto$env:PATHaftercargo install, unlikeInstall-Rustwhich does.Install-Rustis a no-op) and~/.cargo/binis not in the inherited PATH, thetree-sitterbinary cannot be found byExport-GrammarBinding.Install-Rustalready uses.Repro
Build from Linux where
~/.cargo/binis not in the shell's default PATH. The build fails with:Fix
Contact: johan.kallio@teamtech.se for questions.