Type dependent checks: Checks at all components #1120
Draft
+47
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Bharambe <[email protected]>
nitbharambe
commented
Sep 10, 2025
| @@ -27,9 +27,56 @@ | |||
| #include "component/voltage_sensor.hpp" | |||
|
|
|||
| namespace power_grid_model { | |||
| namespace detail { | |||
| template <typename List, typename T, typename... NeedsTypes> | |||
| concept dependent_type_check = !IsInList<T, List>::value || (IsInList<NeedsTypes, List>::value && ...); | |||
There was a problem hiding this comment.
I was checking a different condition previously. It now seems to be possible to move these checks to MainModelType. Ill do so now.
nitbharambe
changed the base branch from
main
to
feature/main-model-refactor-clean-templates-experiment
… into feature/dependent-component-types-check
Signed-off-by: Nitish Bharambe <[email protected]>
This reverts commit d8a7bfa. Signed-off-by: Nitish Bharambe <[email protected]>
… into feature/dependent-component-types-check Signed-off-by: Nitish Bharambe <[email protected]>
… into feature/dependent-component-types-check Signed-off-by: Nitish Bharambe <[email protected]>
nitbharambe
commented
Sep 11, 2025
|
|
||
| template <typename CompList> | ||
| concept validate_component_types_c = | ||
| dependent_type_check<CompList, Source, Node> && // |
There was a problem hiding this comment.
// in the end to avoid formatting
nitbharambe
commented
Sep 11, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/main_model_type.hpp
Outdated
Show resolved
Hide resolved
…ain_core/main_model_type.hpp Signed-off-by: Nitish Bharambe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussions around #1109 , we bumped into the question about dependent types. Hence a separate PR for discussing/solving this issue.
I had initially thought of having this constraint on MainModelType. But what if we included this check at all_components.hpp only? (Edit: Moving back to MainModelType)