Code quality: update Ruff Rules (Bandit, S)#377
Code quality: update Ruff Rules (Bandit, S)#377figueroa1395 merged 15 commits intoPowerGridModel:mainfrom
Conversation
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Update ruff2
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
|
After replacing |
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
|
@mgovers a number of TODOs are present in |
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
left a comment
There was a problem hiding this comment.
apologies for the merge mess i caused. there was a merge conflict in the uv.lock and i messed up during the manual merge. i've force-pushed to undo the bugged change and now it's in a good state again.
@figueroa1395 and/or @nitbharambe can one of you do a final review? I don't want to sign off cause i did some changes myself as well.
figueroa1395
left a comment
There was a problem hiding this comment.
Hello @furqan463, I gave an additional review as requested by @mgovers. Most comments are either very minor or questions from my side. This should be easy to resolve and be good to go soon.
Thanks again for the contribution!
@furqan463 I just noticed we never replied to this message. I see indeed some (if not all) the unit tests comments no longer apply. Can you also remove the ones that have already been added? |
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Relates issue: #352
Adds ruff lint rules Bandit "S".