Feat: support adding multiple nodes/branches at once (performance increase) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
changed the title
|
Signed-off-by: jaapschoutenalliander <[email protected]>
Co-authored-by: Jaap Schouten <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
DCO Remediation Commit for Thijs Baaijen <[email protected]> I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: b1601a8 I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 0598eb8 I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 82d52f9 Signed-off-by: Thijs Baaijen <[email protected]>
|
jaapschoutenalliander
approved these changes
Mar 12, 2025
Signed-off-by: Thijs Baaijen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustworkxsupports adding multiple nodes/branches at once. This is much faster than one by one.I've updated the code to support this.
benefits
Should increase performance of methods like
Graph.from_arraysandGrid.from_cacheside-effects
Introduces some breaking changes as some methods on the
BaseGraphModelhave been renamed:add_node->add_node_arrayadd_branch->add_branch_arrayadd_branch3->add_branch3_arrayOn the other hand, I don't expect this to break much in existing projects, because in general the
Graph.add_branchandGraph.add_nodefunctions are not directly used (e.g.,Grid.appendandGrid.add_nodeare used instead)Performance comparison
Existing code (main):
New code:
