Add support to the new WALLET RRType #15449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miodvallat
reviewed
Apr 18, 2025
| @@ -974,6 +976,8 @@ static void reportOtherTypes(const ReportIsOnlyCallableByReportAllTypes& guard) | |||
| L32RecordContent::report(guard); | |||
| L64RecordContent::report(guard); | |||
| LPRecordContent::report(guard); | |||
| DNSRecordContent::regist(QClass::ANY, QType::WALLET, &WALLETRecordContent::make, &WALLETRecordContent::make, "WALLET"); | |||
There was a problem hiding this comment.
That regist call is probably not necessary as long as you keep the report call below.
Pull Request Test Coverage Report for Build 14528619324Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Checklist
I have:
I've replicated the same behavior as the
TXTRR type since the RFC only defines this. Resolving this issue. Also, tried to keep it close to the BIND implementation which is also very close to its TXT implementation.