auth: try to find ldap libs in case pkconfig is missing (happens on debian11)

[omoerbeek]

Short description

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[Habbie]

with this change, what happens if the libraries really are not there?

[omoerbeek]

with this change, what happens if the libraries really are not there?

Good question, did not test that, will do.

[omoerbeek]

Setup does succeed, but compile fails.

  LDAP
    LDAP                      : NO
    LBER                      : NO
    Krb5                      : YES
    Krb5 Name                 : krb5
    Krb5 Version              : 1.18.3

and then

FAILED: modules/libldapbackend.a.p/ldapbackend_ldapauthenticator.cc.o 
ccache c++ -Imodules/libldapbackend.a.p -Imodules -I../modules -I. -I.. -I../pdns -Iext/arc4random -I../ext/arc4random -Iext/ipcrypt -I../ext/ipcrypt -Iext/json11 -I../ext/json11 -I../ext/luawrapper/include -I../ext/protozero/include -Iext/yahttp -I../ext/yahttp -I/usr/include/luajit-2.1 -I/usr/include/x86_64-linux-gnu -I/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c++17 -O2 -g -DHAVE_CONFIG_H -Wshadow -Wmissing-declarations -Wredundant-decls -Wno-ignored-attributes -fstack-protector --param=ssp-buffer-size=4 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DBOOST_CONTAINER_USE_STD_EXCEPTIONS -fPIC -isystem /usr/include/mit-krb5 -DBOOST_ALL_NO_LIB -pthread -MD -MQ modules/libldapbackend.a.p/ldapbackend_ldapauthenticator.cc.o -MF modules/libldapbackend.a.p/ldapbackend_ldapauthenticator.cc.o.d -o modules/libldapbackend.a.p/ldapbackend_ldapauthenticator.cc.o -c ../modules/ldapbackend/ldapauthenticator.cc
In file included from ../modules/ldapbackend/ldapauthenticator_p.hh:22,
                 from ../modules/ldapbackend/ldapauthenticator.cc:21:
../modules/ldapbackend/ldapauthenticator.hh:21:10: fatal error: ldap.h: No such file or directory
   21 | #include <ldap.h>
      |          ^~~~~~~~
compilation terminated.

[miodvallat]

This was to be expected. Without pkgconfig information, you have been able to find the library, but you also need to find the header files...

Edit: nevermind, I had not noticed you were building without the library.

[omoerbeek]

This was to be expected. Without pkgconfig information, you have been able to find the library, but you also need to find the header files...

The setup run should have failed as I ran meson setup -Dmodule-ldap=static without having ldap.

[coveralls]

Pull Request Test Coverage Report for Build 12952588052

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 50 unchanged lines in 13 files lost coverage.
• Overall coverage increased (+0.01%) to 64.71%

---

Files with Coverage Reduction	New Missed Lines	%
modules/gpgsqlbackend/gpgsqlbackend.cc	1	88.62%
pdns/validate.cc	1	68.09%
pdns/pollmplexer.cc	1	83.66%
pdns/misc.cc	2	62.82%
pdns/misc.hh	3	87.62%
pdns/packethandler.cc	3	72.4%
pdns/iputils.cc	3	56.07%
modules/gpgsqlbackend/spgsql.cc	3	67.94%
pdns/dnsdistdist/dnsdist-lbpolicies.cc	4	70.3%
pdns/recursordist/rec-tcp.cc	4	66.54%

Totals
Change from base Build 12944046345:	0.01%
Covered Lines:	127871
Relevant Lines:	166476

---

💛 - Coveralls

[Habbie]

nice. I wonder whether required: true on line 9 (and maybe 17?) would be simpler, or perhaps I am missing something.

[omoerbeek]

I think the execution than bails out early and the alternative method does not get run