Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdnsutil: check for key presence after import #15080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This applies the same "fetch key after add" verification logic, added to pdnsutil add-zone-key command recently, to the import-zone-key and import-zone-key-pem commands.

Checklist

I have:

  • read the CONTRIBUTING.md document although not recently
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code (somehow)
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12927476221

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.005%) to 64.706%

Files with Coverage Reduction New Missed Lines %
pdns/misc.cc 1 63.04%
ext/json11/json11.cpp 1 64.49%
pdns/backends/gsql/gsqlbackend.hh 1 97.71%
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/recursordist/rec-main.cc 3 62.41%
pdns/recursordist/syncres.cc 4 80.02%
pdns/packethandler.cc 6 73.05%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.6%
Totals Coverage Status
Change from base Build 12927190209: 0.005%
Covered Lines: 127850
Relevant Lines: 166477

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants