Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: do additional processing for NAPTR #12966

Closed
wants to merge 2 commits into from
Closed

auth: do additional processing for NAPTR #12966

wants to merge 2 commits into from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Jun 29, 2023

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.9.0 milestone Jun 29, 2023
@Habbie Habbie marked this pull request as draft June 29, 2023 12:15
@Habbie
Copy link
Member Author

Habbie commented Jun 29, 2023

This also needs to handle "S" type NAPTRs, which point to SRV, and the names in those SRVs then need to be looked up as A/AAAA.

omoerbeek
omoerbeek reviewed Jun 29, 2023
View reviewed changes
pdns/packethandler.cc
if (flags.find('a') != string::npos) {
content = naptrcontent->d_replacement;
} else {
content.clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue; ?

@Habbie Habbie modified the milestones: auth-4.9.0, auth-5 Feb 15, 2024
@miodvallat miodvallat mentioned this pull request Jan 24, 2025
Merged
8 tasks
@Habbie
Copy link
Member Author

Habbie commented Feb 3, 2025

replaced by #15083

@Habbie Habbie closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek left review comments

Assignees
No one assigned
Labels
auth enhancement
Projects
None yet
Milestone
auth-5
Development

Successfully merging this pull request may close these issues.
2 participants
@Habbie @omoerbeek