fix: hashtables <1.4.1 fail to build with GCC 15 #4315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces hashtables >= 1.4.1 requirement
|
|
||
| -- avoid hashtables pre-1.4.1 that fail to build with GCC 15; see https://github.com/gregorycollins/hashtables/issues/98 | ||
| constraints: | ||
| hashtables >= 1.4.1 |
There was a problem hiding this comment.
This line causes rebuilds for Nix, too - which we don't need, because we're not running GCC 15 there, yet.
You can see this in the failing CI jobs:
hashtables-1.4.2 (lib) (requires download & build)
Maybe we should just do something like allow-newer here for it or so. The stack deps are pinned anyway, and Nix could happily use the older version.
There was a problem hiding this comment.
or maybe just remove it altogether from cabal.project? next nixpkgs upgrade will either have 1.4.2 since it's next version in stackage or won't build in case of GCC upgrade only and will be fixed subsequently
There was a problem hiding this comment.
if removal works, then yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro:
stack buildExpected: compilation succeds
Instead: build fails building
hashtables-1.3.1, reproducing gregorycollins/hashtables#98This PR makes sure
hashtables' version is >= 1.4.1, one with the issue fixed. Stack.yaml specifies 1.4.2 because it's the next version after in the stackage snapshots: https://github.com/commercialhaskell/stackage-snapshots/blob/master/lts/24/0.yaml#L5300