fix: survey actions #33013
Merged
fix: survey actions #33013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added proper mounting of the actions model in the SurveyEdit component to fix survey actions functionality.
- Added
useMountedLogic(actionsModel)hook infrontend/src/scenes/surveys/SurveyEdit.tsxto ensure actions model is properly initialized - This change ensures survey actions work correctly when users perform actions that should trigger surveys
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 3.74 MB ℹ️ View Unchanged
|
what does not work? |
marandaneto
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
survey triggered by actions are currently disabled because they break the
surveyFormlogic.The reason this is happening is because it relies on an logic that is not necessarily mounted within the Surveys logic.
Changes
Make sure to initialize the
actionsModellogic, by usinguseMountedLogic. This will allow us to re-enabled action triggers on surveys, which was also recently requested in a support ticket.Otherwise, when someone tries to add an action to a survey, it causes the form to crash