This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
Refactor plugin not to rely on historic export internals #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rather than re-serialize all events for graphile, call function to export directly 2. Remove dependency on historical exports from code - users should trigger an export themselves
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We recently rebuilt how historical exports work from the ground up and none of this code works with that.
Users also manage to set debug in production, causing an incident on the weekend due too too large logs.
After this Users should trigger a data export from UI.
If we'll go this route, we'll also need to update the documentation for this plugin.
Related: