fix: custom host with a path #290
Merged
+235
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
pauldambra
reviewed
Jan 30, 2025
marandaneto
reviewed
Jan 30, 2025
marandaneto
approved these changes
Jan 30, 2025
|
@ioannisj guessing I can close bcheidemann-kmbal#1 as this PR does (near enough) the same thing? EDIT: I see I raised the PR against a fork anyway 🙈 |
Hey @bcheidemann, so sorry! I completely missed that and didn't see a notification! That's a pity, cause it was looks like most (if not all) of the work was already done for this! Yeah, I think that the fact that it was not against this repo had something to do with it! Thank you for the effort and time though! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #274
💚 How did you test it?
Added some unit tests
📝 Checklist