fix: identify mac catalyst

[ioannisj]

💡 Motivation and Context

see: https://posthog.com/questions/i-os-app-also-available-for-mac-os-is-not-showing-any-mac-os-users-in-product-analytics

Identify as macOS when running on Mac Catalyst or compatibility mode (Designed for iPad/iPhone).

Here are the keys for the two cases:

Mac Catalyst

"$device_manufacturer": "Apple"
"$device_model": "Mac15,6"
"$device_name: "macbook-pro.local"
"$device_type": "Desktop"
"$is_emulator": "false"
"$is_ios_running_on_mac": "false"
"$is_mac_catalyst_app": "true"
"$os_name: "macOS"
"$os_version": "15.1.1"

iOS App running on Mac (Designed for iPad/iPhone)

"$device_manufacturer": "Apple"
"$device_model": "Mac15,6"
"$device_name": "macbook-pro.local"
"$device_type": "Desktop"
"$is_emulator": "false"
"$is_ios_running_on_mac": "true"
"$is_mac_catalyst_app": "false"
"$os_name": "macOS"
"$os_version": "15.1.1"

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• I updated the docs if needed.
• No breaking change or entry added to the changelog.

[marandaneto]

what does hostName return here? this is about the device name (Model), and not the user's name or device's nickname

[ioannisj]

This is equivalent to Host.current().localizedName that we already use on macOS targets (Host is not available on Catalyst).

I think both return the computer name which could leak PII actually, which I agree is concerning. We describe $device_name, however, as "Name of the device" in taxonomy

Regarding the actual device model, we capture as $device_model

[marandaneto]

this should be the info of the physical device.
So if we're using Host.current().localizedName because device.model isn't possible, then lets keep it

[pauldambra]

fly-by that I appreciate the care and attention on this PR... some decisions are pretty hard to change and these posthog provided props are definitely that 💖

[octohub]

@pauldambra @ioannisj Thank you so much for the work on this. Excited to leverage it! How can I track when this will be in a published version of the SDK?

[marandaneto]

@pauldambra @ioannisj Thank you so much for the work on this. Excited to leverage it! How can I track when this will be in a published version of the SDK?

https://github.com/PostHog/posthog-ios/releases/tag/3.19.3 :)