Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure we can deploy multiple releases in separate namespaces #454

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

hazzadous
Copy link
Contributor

This is partially to ensure we can run tests in clean envs, but is also
relevant to uses e.g. wanting to run prod and staging in the same
cluster.

Previously ClusterRoles and ClusterRoleBindings for the
clickhouse-operator were not unique, this uses the namespace to correct
that.

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@guidoiaquinti guidoiaquinti force-pushed the support-multiple-namespaces branch 7 times, most recently from bb68cf9 to 134b70a Compare June 30, 2022 14:43
Harry Waye added 2 commits June 30, 2022 16:50
This is partially to ensure we can run tests in clean envs, but is also
relevant to uses e.g. wanting to run prod and staging in the same
cluster.

Previously ClusterRoles and ClusterRoleBindings for the
clickhouse-operator were not unique, this uses the namespace to correct
that.
@guidoiaquinti guidoiaquinti force-pushed the support-multiple-namespaces branch 2 times, most recently from 352cc1e to e764dce Compare June 30, 2022 15:22
@guidoiaquinti
Copy link
Contributor

This PR ended up being more than a couple of changes. Here's a list of what has been done:

  • refactor the current pytest parallelism as each test is now independent from others
  • made clusterrole and clusterrolebinding coming from the clickhouse-operator unique across the namespace
  • added in conftest logic to automatically wipe both k8s and helm before the start of each test
  • minor fixes to black/isort/flake8 config
  • disabled few flaky/broken tests (like clickhouse sharding, clickhouse backup, and Job migrate - CH multishard/replica provision race condition #462). I will fix those in a follow up PR but there's no point to block the pipeline for those

@guidoiaquinti guidoiaquinti force-pushed the support-multiple-namespaces branch from e728942 to 97010b1 Compare July 1, 2022 08:48
@guidoiaquinti guidoiaquinti merged commit 6f2f5b7 into main Jul 1, 2022
@guidoiaquinti guidoiaquinti deleted the support-multiple-namespaces branch July 1, 2022 09:42
@posthog-bot
Copy link

We probably forgot to bump the chart with this merge. No worries head over to https://github.com/PostHog/charts-clickhouse/actions/workflows/bump-version-workflow-dispatch.yaml to trigger the chart update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants