Merged
Conversation
…event to raise (fixes #52).
Test Results260 tests 260 ✅ 1m 23s ⏱️ Results for commit a104b00. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rules
+= nullsyntax when raising events withRaise()/RaiseAsync()(fixes Check that no delegate is passed to the event when calling Raise()/RaiseAsync() methods. #52).SetupSequence()methods. (fixes Add the support of SetupSequence() for all the rules. #33).Mock<T>.Raise()/RaiseAsync()must use parameters matching the event signature (fixes Check the arguments of the Raise()/RaiseAsync() method arguments. #51).Raise()/RaiseAsync()must be an event (fixes Check the arguments of the Raise()/RaiseAsync() method arguments. #51).RaiseAsync()must be used only for events with async handlers (returningTask) (fixes Check the arguments of the Raise()/RaiseAsync() method arguments. #51).This is a major improvement to detect the bug of Moq related to the .RaiseAsync throws exception when used with a void delegate, no exception info for wrong using devlooped/moq#1568 issue (and the related PR Fix for #1568 when RaiseAsync with a void Delegate returns null results in System.NullReferenceException devlooped/moq#1571 proposed fix which is still not approved).
New fixers
VerifyAll()call at the end of the unit tests. #53).