Upgrade to 0.29. Add EU language #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade to 0.29 * update CI * fix tests * fix tests * fix test * Apply suggestions from code review Co-authored-by: Ivan Vergés <[email protected]> * Update Gemfile and lockfile for Decidim 0.29.2 * fix accessibility test * add overrides_spec * fix custom_country_select --------- Co-authored-by: Ivan Vergés <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .ruby-version: Language not supported
Comments suppressed due to low confidence (2)
spec/factories.rb:11
- Changing the factory 'name' attribute from a string to a locale-indexed hash may introduce type mismatches if the consuming code expects a string. Please verify that all tests and methods using this factory support the new hash format.
name { Faker::Company.unique.name }
app/commands/concerns/decidim/extra_user_fields/update_account_commands_overrides.rb:14
- Replacing '@user' with 'current_user' requires confirmation that 'current_user' is always available and set in this context. Please ensure that this change is consistently supported across the application.
current_user.locale = @form.locale
* upgrade to 0.29 * update CI * fix tests * fix tests * fix test * Apply suggestions from code review Co-authored-by: Ivan Vergés <[email protected]> * Update Gemfile and lockfile for Decidim 0.29.2 * fix accessibility test * add overrides_spec * fix custom_country_select --------- Co-authored-by: Anna Topalidi <[email protected]> Co-authored-by: Anna Topalidi <[email protected]>
* add gender options * add age range * add translations * add readme * fix locales
* add custom select fields * specs * erb lint * specfix * fix specs * readme
* add custom boolean fields * fix specs
* add custom text fields * add custom text fields * readme
* allow proc * change context * add example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Basque language!