Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of entrezgene XML ASN1 data structure #33

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

smoe
Copy link
Contributor

@smoe smoe commented Dec 13, 2024

I felt a bit overwhelmed with the XML implementation bits. Maybe you can give me a helping hand / directions on those. As a consequence the tests did not test anything :-) But it all builds and does not complain too much.

@PoorRican
Copy link
Owner

PoorRican commented Dec 14, 2024

I built this program for viewing the XML files which might help with navigating the actual XML file: https://github.com/PoorRican/browsr. Hopefully this solves some of your frustrations.

Just read your comment, I will see if I can get this running over the weekend.

@smoe
Copy link
Contributor Author

smoe commented Dec 14, 2024 via email

@smoe
Copy link
Contributor Author

smoe commented Dec 15, 2024

I have added a considerable amount of implementation work locally - please do not also work on it. :-/ Sorry for the late warning.

@smoe
Copy link
Contributor Author

smoe commented Dec 16, 2024

The parsers now parse but somehow they do not do their job :-/ It is likely something stupid somewhere but I cannot find it.

@smoe
Copy link
Contributor Author

smoe commented Dec 22, 2024

@PoorRican May I ask for some comments from your side?

@PoorRican
Copy link
Owner

PoorRican commented Dec 25, 2024

@smoe Will be working on this today. Merry Xmas.

@smoe
Copy link
Contributor Author

smoe commented Jan 1, 2025

Think I now at least know what my biggest problems are.

  • I have ruined the parsing of dates. Did not work for me before, or I have not understood them :-) So I feel not completely bad at this very moment. Have now commented out the respective tests.
  • I have a problem with parsing the numeric values of an enum. This ruins the EntrezgeneType and others.

@smoe
Copy link
Contributor Author

smoe commented Jan 4, 2025

I am still a bit inconsistent with how the assignments of numerical values that are represented as text in XML to enums should work. Anyway - got somewhere. Want to add some more tests and please direct me as you see fit.

@smoe
Copy link
Contributor Author

smoe commented Jan 6, 2025

@PoorRican , have added two tests - it now basically works. But more tests are needed as every test added somehow spotted an issue with naming of attributes or something else. :-)

@PoorRican PoorRican merged commit 7ed4589 into PoorRican:master Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants