-
Notifications
You must be signed in to change notification settings - Fork 60
Time semantics overhaul #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ljeub-pometry
wants to merge
173
commits into
master
Choose a base branch
from
feature/IsValidFilter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Time semantics overhaul #1969
+19,018
−15,064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f2d03d
to
dfbb7a8
Compare
…eView to make some implementations possible
14b8b49
to
bab1997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: 816506e | Previous: c8f2a0f | Ratio |
---|---|---|---|
lotr_graph_window_50_layered/iterate edges |
117827 ns/iter (± 327 ) |
50232 ns/iter (± 81 ) |
2.35 |
lotr_graph_persistent_window_50_layered/has_node_existing |
117 ns/iter (± 77 ) |
27 ns/iter (± 0 ) |
4.33 |
lotr_graph_persistent_window_50_layered/iterate nodes |
29082 ns/iter (± 94 ) |
9018 ns/iter (± 13 ) |
3.22 |
This comment was automatically generated by workflow using github-action-benchmark.
… the private storage available
…y-storage still needs the storage feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add_node
.add_node
.latest_time
semantics for the PersistentGraph to return the time of the last update for the node/edge/graph in the current view or the start of the window if there are no updates.earliest_time
andlatest_time
within a filtered Event Graph will now reflect the updates within the graph view instead of just window bounds.Why are the changes needed?
Fixes #1050, fixes #1787, fixes #1191
Fixes #1779
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?