Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oregon LIHEAP #5333

Draft
wants to merge 61 commits into
base: master
Choose a base branch
from
Draft

Conversation

srilareddy
Copy link
Collaborator

Fixes #273

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.03%. Comparing base (cb92a56) to head (2a2e2b4).
Report is 251 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5333      +/-   ##
==========================================
- Coverage   99.12%   99.03%   -0.10%     
==========================================
  Files        2592     2634      +42     
  Lines       37707    38299     +592     
  Branches      162      165       +3     
==========================================
+ Hits        37378    37930     +552     
- Misses        297      335      +38     
- Partials       32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have two files:
or_liheap_eligibility.py

or_liheap_income_threshold.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add unit tests for each individual file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog_entry

@PavelMakarchuk
Copy link
Collaborator

Next step for us is to find the payout amount for the program and see how much people can get - there should be some guidelines

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next step is add amounts and payouts

Comment on lines 24 to 32
class liheap_payout(Variable):
value_type = float
entity = SPMUnit
definition_period = YEAR
defined_for = StateCode.OR
label = "LIHEAP Payout"

def formula(SPMUnit, period, parameters):
payout = SPMUnit("utility_type", period)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a separate .py file

Suggested change
class liheap_payout(Variable):
value_type = float
entity = SPMUnit
definition_period = YEAR
defined_for = StateCode.OR
label = "LIHEAP Payout"
def formula(SPMUnit, period, parameters):
payout = SPMUnit("utility_type", period)
class liheap_payout(Variable):
value_type = float
entity = SPMUnit
definition_period = YEAR
defined_for = StateCode.OR
label = "LIHEAP Payout"
def formula(spm_unit, period, parameters):
utility_type = spm_unit("utility_type", period)
unit_size = spm_unit("spm_unit_size", period)
clipped_income_range = clip(unit_size, 1, 6)
income_range = spm_unit("or_liheap_income_range", period)
p = ......
region_one = ...
return where(p.region_one[unit_size][income_range][utility_type], p.region_two...)

Comment on lines +4 to +8
spm_unit_size: 1
county: CURRY_COUNTY_OR
state_code: OR
output:
region: REGION 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spm_unit_size: 1
county: CURRY_COUNTY_OR
state_code: OR
output:
region: REGION 1
county_str: CURRY_COUNTY_OR
state_code: OR
output:
or_liheap_in_region_one: REGION 1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the output mirrors the class and the inputs are only variables used in the specific formula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oregon LIHEAP
2 participants