-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero out SPM broadband subsidy effective 2024-06-01 #5119
Draft
liwenxin491
wants to merge
10
commits into
PolicyEngine:master
Choose a base branch
from
liwenxin491:liwenxin491/issue5003
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
97b859c
Zero out SPM broadband subsidy effective 2024-06-01
liwenxin491 009f00f
Zero out SPM broadband subsidy effective 2024-06-01
liwenxin491 852ae5b
Zero out SPM broadband subsidy effective 2024-06-01
liwenxin491 289db08
Zero out SPM broadband subsidy
liwenxin491 dcbefe5
Merge branch 'master' of https://github.com/PolicyEngine/policyengine…
liwenxin491 c6f2246
Add tests starting from 2025.
liwenxin491 5abc376
Merge branch 'master' into liwenxin491/issue5003
liwenxin491 0566acc
Zero out SPM broadband subsidy effective 2024-06-01
liwenxin491 d163243
add test for 2025
liwenxin491 5808e3f
add test for 2025
liwenxin491 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
||
2 changes: 2 additions & 0 deletions
2
policyengine_us/parameters/gov/simulation/reported_broadband_subsidy.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
description: Broadband subsidies are taken as reported in the CPS ASEC. | ||
values: | ||
2000-01-01: true | ||
2024-06-01: false # ACP ends | ||
metadata: | ||
unit: bool | ||
liwenxin491 marked this conversation as resolved.
Show resolved
Hide resolved
liwenxin491 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
period: year | ||
label: Use reported broadband subsidies |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,12 +15,11 @@ | |
output: | ||
spm_unit_broadband_subsidy: 5 | ||
|
||
- name: Baseline subsidy test with relevant inputs | ||
period: 2023 | ||
- name: Households with reported broadband subsidies have zero starting in 2025 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you keep this test as it is and add a new one for 2025 |
||
period: 2025 | ||
input: | ||
gov.simulation.reported_broadband_subsidy: false | ||
acp: 1 | ||
ebb: 2 | ||
output: | ||
spm_unit_broadband_subsidy: 3 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add changelog