Feat/landing page #216
Feat/landing page #216
Conversation
|
Before I review, can you move the images to the |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Thanks for this @AnushkaNilangekar! A few changes/questions requested, but if you could do those and fix the merge conflicts, we should be able to get this in soon.
| 0px 4px 6px -1px rgba(0, 0, 0, 0.10) | ||
| `, | ||
| zIndex: 1000, | ||
| fontFamily: typography.fontFamily.primary, |
There was a problem hiding this comment.
issue?: I'm not sure this font family setting is properly populating to items below. Could you verify and, if not, attempt to set lower in the stack, as perhaps something's overriding it?
|
|
||
| <Group gap={spacing['3xl']} visibleFrom="lg"> | ||
| {links.map((label) => ( | ||
| <Anchor |
There was a problem hiding this comment.
In fact, the Anchor here might be setting a default that needs to be over-ridden
| /> | ||
| ); | ||
|
|
||
| const HeaderNavigation: React.FC = () => { |
There was a problem hiding this comment.
issue: When scrolling down on the page, this header bar scrolls out of view. Could you "sticky" the location of this header bar and, as the user scrolls down, have it expand to fill 100% of the width of the screen and ensure it sits on the top of the page? That way it's always visible.
| const HeaderNavigation: React.FC = () => { | ||
| const [opened, { open, close }] = useDisclosure(false); | ||
|
|
||
| const links = ['Research', 'About', 'Donate']; |
There was a problem hiding this comment.
suggestion: I'd code this up as an array of custom-interfaced objects with keys like "label" and "link" or something like that, then later in the component, programmatically use useNavigate to visit a given link.
There was a problem hiding this comment.
question, non-blocking: Are you familiar with image minimizing?
If so, please add a second folder that contains minimized images, then import those and have them load here. If not, no need.
| </Box> | ||
|
|
||
| <OrgLogos | ||
| logos={[ |
There was a problem hiding this comment.
suggestion: Define the logos structure you build here elsewhere (maybe even in a separate file, but not necessarily, I'm torn on that myself) and use here.
| logos={[ | ||
| { | ||
| id: '1', | ||
| src: f4gi, |
There was a problem hiding this comment.
question: What is the purpose of the src item here?
2 participants
Description
Added a new Landing Page that serves as the default entry point. The page introduces PolicyEngine’s mission, provides quick navigation, and highlights partner organizations in a responsive layout.
Changes
Preview
https://www.loom.com/share/b29a7f0723f74c6981cd7b354611a5eb?sid=c8f15955-ffaf-4b82-a762-0a4187ea0dd5