Bump @policyengine/ui-kit to ^0.8.0#17
Merged
Merged
Conversation
Picks up dark mode tokens, Quarto SCSS theme, WCAG contrast matrix CI, accessible text variants, and the legacy compat shim shipped in 0.4.0–0.8.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![policyengine[bot]](https://avatars.githubusercontent.com/u/88570531?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean bump from ui-kit 0.4.0 → 0.8.0. The codebase only consumes CSS custom properties from ui-kit (no component imports), so the upgrade surface is minimal.
Verified:
- Lock file correctly resolves to @policyengine/ui-kit@0.8.0
- No direct imports of ui-kit components—only CSS theme via
@import "@policyengine/ui-kit/theme.css" - Color token references use fallback values (e.g.,
var(--text-warning, #d9480f)) so the code gracefully degrades if tokens are missing - The
--destructivetoken mentioned in the PR description isn't used anywhere in the app code app/public/paper/web/pe-tokens.cssis a frozen snapshot from the old design-system (not modified in this PR) and won't be affected- app/src/app/theme.css:34 uses
--text-warningwith the old fallback#d9480f, which will now resolve to the new ui-kit value#c2410c(darker, better contrast per the PR description)
What's good:
The fallback values in theme.css provide a safety net. The PR correctly identifies the only visual changes: --text-warning darkening from #d9480f → #c2410c for WCAG compliance. Since PolicyBench doesn't use --destructive, that change is irrelevant.
No issues found. The upgrade is backward-compatible for this codebase's usage pattern.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Vercel only loads vercel.json from the project root directory, which the policybench-site project has set to '.'. The previous app/vercel.json worked for direct CLI deploys (where the CLI uploads from app/) but was ignored by the git integration that drives PR previews — Vercel was running 'bun install' at the repo root, which has no package.json. Add a root vercel.json that runs install/build inside app/ and points the output directory at app/.next, matching the pattern used by other PolicyEngine repos with Next.js apps in subdirectories (e.g. spm-calculator). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This reverts commit cfcd04e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@policyengine/ui-kitfrom^0.4.0to^0.8.0. Picks up:--text-warning,--text-error,--text-success(0.5.0)@policyengine/ui-kit/legacycompat shim for the deprecated design-system (0.8.0)No breaking API changes for current consumers; the only resolved-color shifts are
--destructive#EF4444 → #DC2626and--text-warning#d9480f → #c2410c, both darker for AA compliance. Verify nothing visual breaks.Test plan
🤖 Generated with Claude Code