adding effects of missing abilities

[digitalghost-dev]

Hello, there are about 80 abilities missing from the ability_prose.csv file. I have added every ability from 234 to 307. Only English translation, however.

[Naramsim]

Thanks! I think you need to add another column. You can check the CSV header

[digitalghost-dev]

Oh shoot, I didn't see that. I will add a short effect column from pokemondb.net

[digitalghost-dev]

@Naramsim - I believe all 4 columns are there now. I couldn't find a short_effect for some of the abilities or some just repeated the long or "standard" effect. Does every ability need a short_effect?

[Naramsim]

@Naramsim - I believe all 4 columns are there now. I couldn't find a short_effect for some of the abilities or some just repeated the long or "standard" effect. Does every ability need a short_effect?

Hi, yes, so far we have collected both descriptions. As those were in games roms. If now we don't have anymore any distinction, maybe we could make the short_effect optional. Can you reference here a move that you couldn't find both descriptions for?

[digitalghost-dev]

One example is for Poison Puppeteer. There is only an effect listed (which could be used as the short_effect and then the flavor_text_entry would be null in this case).

However, we could use the effect listed for both? For example, Pokémon poisoned by Pecharunt’s moves will also become confused. could be used for both the short_effect and the flavor_text_entry.

[Naramsim]

I think the best is to use Bulbapedia: https://bulbapedia.bulbagarden.net/wiki/Poison_Puppeteer_(Ability)

On the right side there's the flavor text which goes to the csv ability_flavor_text.csv.

Below, under Effect -> In battle, we could use that string as the effect in the ability_prose.csv file. short_effect can be a brief summary written by you (if you have the time). Even better the short_effect can be taken from Serebii's Game's text: https://www.serebii.net/abilitydex/poisonpuppeteer.shtml

[digitalghost-dev]

@Naramsim - okay, every record has both an effect and short_effect now!

[Naramsim]

The pipeline fails, I think an issue might be all these newlines. Can you remove them?

[digitalghost-dev]

I assume that a line is needed on 1248?

This Ability is not bypassed by []{ability:mold-breaker}, []{ability:teravolt}, or []{ability:turboblaze}."
233,9,Increases super-effective damage dealt to 1.25×.,Increases super-effective damage dealt to 1.25×.

234,9,"Boosts Attack in battle.","Boosts the Pokémon’s Attack stat the first time the Pokémon enters a battle."
235,9,"Boosts Defense in battle.","Boosts the Pokémon’s Defense stat the first time the Pokémon enters a battle."

That is the only remaining newline that I see now after removing all the others.

[Naramsim]

No newlines are allowed I think

[digitalghost-dev]

Okay, it took me a second to understand how this is formatted. It looks like there are header sections or comments underneath certain abilities. In other words, the "comment" describes the ability that is above it, not below it. They don't show up in GitHub, only when I cloned the repository and opened it up in my IDE.

I think we are okay now.

[Naramsim]

Thanks @digitalghost-dev, if you want you can add the script you came up with to the Resources/scripts/data folder.

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).