Downgrade zink + some other fixes #6752
Merged
+74
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f88fb3c. Mali devices are severely screwed over by this change.
This makes it override anything that could be set by the launcher, which is the point. Also it looks cleaner imo.
I'm really annoyed at how the version file keeps changing and it seems dumb
Using 8 is causing some really weird unreproducable shitfuckery that is likely related to caches. Co-authored-by: ItsWinterBush <[email protected]>
|
I don't see issues with this from a quick look at the code. |
build.gradle
Outdated
| def command = Runtime.getRuntime().exec("git rev-list -1 HEAD " + project) | ||
| def result = command.waitFor() | ||
| if (result != 0) { | ||
| throw new IOException("Command 'getGitHash()' exited with " + result) |
There was a problem hiding this comment.
Note for a future PR/commit:
Enforce failing the build if the repository isn't cloned with Git. Not cloning with Git breaks submodules and this code already.
There was a problem hiding this comment.
How do you suppose just letting it silently fail and not edit the versions file?
crystall1nedev
approved these changes
Mar 26, 2025
This is to fix `aar-metadata.properties (No such file or directory)` See leancodepl/patrol#2181 for similar issue
|
oh uh oops i mistapped |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.