Fix export import specially for cloud composer#6415
Open
larshg wants to merge 10 commits intoPointCloudLibrary:masterfrom
Open
Fix export import specially for cloud composer#6415larshg wants to merge 10 commits intoPointCloudLibrary:masterfrom
larshg wants to merge 10 commits intoPointCloudLibrary:masterfrom
Conversation
…s/structs should not be decorated with export.
Remove PCL_EXPORTS as it created dublicated export prefixes.
…ud_composer are plugins and should not be imported, but found using qts dll loading system.
…empty. Unify the check for WIN32.
larshg
force-pushed
the
fixdllexportimportcloudcomposer
branch
from
1f7dd40 to
8b30904
Compare
Remember to add defines for CUDA libraries. Only add export flags, if they should be exported. If not the would default to import (cloud composer plugins).
…inux. But still use OPENNURBS_EXPORTS as it was used multiple places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated EXPORT quite a few places after adding __declspec(dllimport).
The plugin libraries of cloud composer need to only import other dlls. So I added that option to PCL_ADD_LIBRARY. Default is still to export symbols.
Makes #6377 unnecessary.
Fixes #2708
Fixes #5336 - I added a check for NO_PRE_COMPILE, since kdtree_flann.cppwould always be added if flann is found. I don't think there are any other libraries that doesn't export something.