Skip to content

Conversation

@NeejWeej
Copy link
Collaborator

@NeejWeej NeejWeej commented Dec 20, 2025

work with PyObjectPath. This allows CallableModels and Context classes to be defined within functions

…ork with PyObjectPath

Signed-off-by: Nijat Khanbabayev <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

Test Results

545 tests  +66   541 ✅ +66   1m 40s ⏱️ +59s
  1 suites ± 0     4 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 52578f2. ± Comparison against base commit d955f57.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 96.35344% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.50%. Comparing base (d955f57) to head (52578f2).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
ccflow/tests/test_local_persistence.py 97.02% 17 Missing ⚠️
ccflow/exttypes/pyobjectpath.py 85.00% 3 Missing and 3 partials ⚠️
ccflow/local_persistence.py 93.10% 0 Missing and 2 partials ⚠️
ccflow/tests/test_base.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   95.35%   95.50%   +0.15%     
==========================================
  Files         130      132       +2     
  Lines        7777     8463     +686     
  Branches      511      521      +10     
==========================================
+ Hits         7416     8083     +667     
- Misses        245      262      +17     
- Partials      116      118       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Nijat Khanbabayev <[email protected]>
@NeejWeej NeejWeej force-pushed the nk/local_model_context_registration branch from 56af912 to 7d85243 Compare December 20, 2025 01:00
Signed-off-by: Nijat Khanbabayev <[email protected]>
@NeejWeej NeejWeej marked this pull request as ready for review December 20, 2025 01:44
@NeejWeej NeejWeej force-pushed the nk/local_model_context_registration branch from 8da4112 to 32ae219 Compare December 20, 2025 01:52
@NeejWeej NeejWeej requested a review from ptomecek December 30, 2025 05:21
@NeejWeej NeejWeej force-pushed the nk/local_model_context_registration branch 3 times, most recently from 9f31941 to a411542 Compare December 30, 2025 07:21
@NeejWeej NeejWeej force-pushed the nk/local_model_context_registration branch from a411542 to b06ea00 Compare December 30, 2025 07:25
@NeejWeej NeejWeej force-pushed the nk/local_model_context_registration branch from 2ba8d19 to f0f3262 Compare December 31, 2025 06:31
@NeejWeej NeejWeej requested a review from ptomecek December 31, 2025 09:36
ptomecek
ptomecek previously approved these changes Dec 31, 2025
@ptomecek
Copy link
Collaborator

@timkpaine You want to have a look at this one?

Signed-off-by: Nijat Khanbabayev <[email protected]>
@NeejWeej NeejWeej requested a review from ptomecek January 7, 2026 20:04
@ptomecek ptomecek changed the title Register locally defined CallableModels and Contexts in a module to Register locally defined BaseModels in a module to work with PyObjectPath Jan 7, 2026
@NeejWeej NeejWeej merged commit 1345a67 into main Jan 7, 2026
6 checks passed
@NeejWeej NeejWeej deleted the nk/local_model_context_registration branch January 7, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants