Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend README.txt to reflect actual state. #601

Open
wants to merge 1 commit into
base: MOODLE_404_STABLE
Choose a base branch
from
Open

Amend README.txt to reflect actual state. #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 3

mariadb:
image: mariadb:10
image: mariadb:10.6
env:
MYSQL_USER: 'root'
MYSQL_ALLOW_EMPTY_PASSWORD: "true"
Expand All @@ -30,6 +30,9 @@ jobs:
fail-fast: false
matrix:
include:
- php: '8.3'
moodle-branch: 'main'
database: 'pgsql'
- php: '8.3'
moodle-branch: 'MOODLE_405_STABLE'
database: 'mariadb'
Expand Down
6 changes: 4 additions & 2 deletions README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ survey tool.
--------------------------------------------------------------------------------
Developers Note:

There is no main branch. Questionnaire is maintained in MOODLE_XX_STABLE
There is no main branch. Questionnaire is maintained in MOODLE_XXX_STABLE
branches. Use the latest STABLE branch for development or installation.
The current stable branch is MOODLE_400_STABLE, and supports Moodle 4.0 and up.
The current stable branch is MOODLE_404_STABLE, and supports Moodle 4.4 and up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely true. The current stable branch (aside from naming) is MOODLE_401_STABLE. It supports Moodle 4.1 through 4.4.
MOODLE_404_STABLE is the current development branch, for the next stable release, and supports Moodle 4.4 and targeting 4.5.

Use the MOODLE_401_STABLE branch for Moodle 4.1 through 4.3.
Use the MOODLE_400_STABLE branch for Moodle 4.0.
Use the MOODLE_311_STABLE branch for Moodle 3.9 through 3.11.

--------------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions tests/custom_completion_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class custom_completion_test extends \advanced_testcase {
*
* @return array[]
*/
public function get_state_provider(): array {
public static function get_state_provider(): array {
return [
'Undefined rule' => [
'somenonexistentrule', COMPLETION_DISABLED, false, null, coding_exception::class
Expand Down Expand Up @@ -178,7 +178,7 @@ public function test_is_defined() {
*
* @return array[]
*/
public function get_available_custom_rules_provider(): array {
public static function get_available_custom_rules_provider(): array {
return [
'Completion submit available' => [
COMPLETION_ENABLED, ['completionsubmit']
Expand Down