Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new question type file #599

Open
wants to merge 1 commit into
base: MOODLE_401_STABLE
Choose a base branch
from

Conversation

srobotta
Copy link

Hi Mike,

this is a new pull request for the new file type question and replaces #559
The original work on the file type has been done by Laurent David (https://github.com/laurentdavid). He introduced this question/response type and also created #471
Luca Bösch added behat tests for the new file type.
I finally fixed a few issues from the original work from Laurent:

  • deletion of left over data when a response or the whole questionnare is deleted.
  • possibility to have multiple file type questions in one questionnaire.

I have taken your latest MOODLE_401_STABLE branch from the plugin and our codebase from BFH where this is already included and created this pull request that just contains the file type.

@srobotta srobotta force-pushed the multi_file_fields branch 3 times, most recently from 7c2da17 to 4a26a1a Compare August 28, 2024 14:01
@mchurchward
Copy link
Contributor

Thank you for all the effort you have put into this. I will review this happily.

@srobotta
Copy link
Author

Just rebased to the latest MOODLE_401_STABLE branch.

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is old, but I was just testing it on MOODLE_404_STABLE and it didn't work.
I had a number of odd issues.

  1. If I saved a response instead of submitting, when I went to resume the questionnaire, my file was not in the file question.
  2. If I then uploaded it again, and submitted, I received the error "Undefined property: stdClass::$itemid" from the responsetype/file class when it went to delete the old response on line 136.
  3. When I did it again, and submitted the first time, it worked. But the response page showed me a question response to rate question from another questionnaire.
  4. I believe this will need backup and restore support code added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants