Compile with C99 features on Windows. #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows (MSVC) has had support for C99 features for quite a while now (since 2013?) so no reason to restrict it to C89, Also some features that are specific to Pluto (such as `math.round`) already have a hard requirement for C99 anyways. In regular PUC Lua the only places that really take advantage of C99 cross-platform are `math.log` when it's second argument is `2` and some core functions around the codebase trying to hint to the compiler to be inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows (MSVC) has had support for C99 features for quite a while now (since 2013?) so no reason to restrict it to C89, Also some features that are specific to Pluto (such as
math.round) already have a hard requirement for C99 anyways.In regular PUC Lua the only places that really take advantage of C99 cross-platform are
math.logwhen it's second argument is2and some core functions around the codebase trying to hint to the compiler to be inlined as far as I can tell.I did a few test compiles myself with MSVC on Windows using the provided solution file just to make sure it didn't throw a fit and all seemed to work fine.