Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add cosmic ray correction #752

Merged
merged 2 commits into from
Dec 23, 2020
Merged

ENH: add cosmic ray correction #752

merged 2 commits into from
Dec 23, 2020

Conversation

dzenanz
Copy link
Contributor

@dzenanz dzenanz commented Dec 18, 2020

No description provided.

@adamrankin
Copy link
Member

Just let us know when to merge.

@dzenanz
Copy link
Contributor Author

dzenanz commented Dec 21, 2020

I think this is ready to merge, but I defer to @jrojasUNC.

@dzenanz
Copy link
Contributor Author

dzenanz commented Dec 23, 2020

... and Juan is on vacation until January. I guess this will keep pending for two more weeks.

jrojasUNC
jrojasUNC approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@jrojasUNC jrojasUNC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I just tested this and it looks good.

@adamrankin adamrankin merged commit 0d03704 into PlusToolkit:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrojasUNC jrojasUNC jrojasUNC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzenanz @adamrankin @jrojasUNC