Skip to content

fix(plugins): support namespaced static exports#158

Open
facontidavide wants to merge 1 commit into
mainfrom
feat/static-plugin-symbols
Open

fix(plugins): support namespaced static exports#158
facontidavide wants to merge 1 commit into
mainfrom
feat/static-plugin-symbols

Conversation

@facontidavide

Copy link
Copy Markdown
Contributor

Summary

  • add backward-compatible *_PLUGIN_NAMED(ClassName, SymbolName, manifest) exports for data sources, message parsers, toolboxes, and dialogs
  • keep the existing macros and generated getter names unchanged for unqualified classes
  • cover all four families with a static compile/runtime test using namespaced plugin classes
  • document the named form in the plugin guides and changelog

This fixes the SDK-level token-paste limitation identified while reviewing PlotJuggler/pj-official-plugins#235. Qualified class names such as mosaico::MosaicoToolbox are valid C++ types but cannot be pasted into a getter identifier; the new form separates the type from the unqualified symbol token.

No ABI or protocol change.

Tests

  • ./build.sh
  • ctest --test-dir build --output-on-failure — 50/50 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant