-
Notifications
You must be signed in to change notification settings - Fork 1
Fill out some basic documentation #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plasmapy_sphinx/__init__.py
Outdated
if sys.version_info < (3, 6): # coverage: ignore | ||
raise ImportError("plasmapy_sphinx does not support Python < 3.6") | ||
if sys.version_info < (3, 8): # coverage: ignore | ||
raise ImportError("plasmapy_sphinx does not support Python < 3.8") | ||
|
||
if sys.version_info >= (3, 8): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the minimum version was just changed to 3.8, we should be able to remove this if/else
block and drop the importlib_metadata
line.
… generate_autosummary_content(), who's signature changes for sphinx >= 8.0
# Conflicts: # .github/workflows/check_install.yml # .github/workflows/documentation.yml
Co-authored-by: Nick Murphy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Thank you for doing this! 🙏🏻
This PR add some basic documentation...
plasmapy.ext.autodoc
,plasmapy.ext.automodsumm
,plasmapy.ext.css
,plasmapy.ext.directive
, andplasmapy.theme
has meaningful content.Note
This PR was originally opened to do what PR #18 is did. Unfortunately this PR scope creeped into being updates to both the documentation and GitHub Workflows. The GitHub Workflow changes have now been broken out into PR #18, and this PR will just contain the documentation update.