Skip to content

Fill out some basic documentation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
May 9, 2025
Merged

Fill out some basic documentation #17

merged 63 commits into from
May 9, 2025

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Apr 25, 2025

This PR add some basic documentation...

  • Add and installation page.
  • Make sure the sphinx extension pages for plasmapy.ext.autodoc, plasmapy.ext.automodsumm, plasmapy.ext.css, plasmapy.ext.directive, and plasmapy.theme has meaningful content.

Note

This PR was originally opened to do what PR #18 is did. Unfortunately this PR scope creeped into being updates to both the documentation and GitHub Workflows. The GitHub Workflow changes have now been broken out into PR #18, and this PR will just contain the documentation update.

if sys.version_info < (3, 6): # coverage: ignore
raise ImportError("plasmapy_sphinx does not support Python < 3.6")
if sys.version_info < (3, 8): # coverage: ignore
raise ImportError("plasmapy_sphinx does not support Python < 3.8")

if sys.version_info >= (3, 8):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the minimum version was just changed to 3.8, we should be able to remove this if/else block and drop the importlib_metadata line.

@rocco8773 rocco8773 changed the title "Modernize" Github Workflows "Modernize" Github Workflows - SCOPE CREEPED - do NOT meger May 6, 2025
@rocco8773 rocco8773 changed the title "Modernize" Github Workflows - SCOPE CREEPED - do NOT meger "Modernize" Github Workflows - SCOPE CREEPED - do NOT merge May 6, 2025
# Conflicts:
#	.github/workflows/check_install.yml
#	.github/workflows/documentation.yml
@rocco8773 rocco8773 added the documentation Improvements or additions to documentation label May 7, 2025
@rocco8773 rocco8773 changed the title "Modernize" Github Workflows - SCOPE CREEPED - do NOT merge Fillout some basic documentation May 7, 2025
@rocco8773 rocco8773 changed the title Fillout some basic documentation Fill out some basic documentation May 7, 2025
@rocco8773 rocco8773 marked this pull request as ready for review May 7, 2025 01:03
@rocco8773 rocco8773 requested a review from namurphy May 7, 2025 01:03
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for doing this! 🙏🏻

@rocco8773 rocco8773 merged commit 053627d into main May 9, 2025
15 checks passed
@rocco8773 rocco8773 deleted the overhaul_workflows branch May 9, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants