-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Cleaning up TS sample files - part 1 #18069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @GTFalcao lgtm! Ready for release!
Changing sample .ts apps to .mjs, removing their .gitignore and tsconfig.json, and updating their package.json to reflect this update.
There are more app files - I'm splitting the result into a few separate PRs to avoid publishing more than a hundred packages at once.
Also cleaning up the root tsconfig.json as it has a LOT of duplicate references as well as the apps being removed.
Finally, adjusted the report script for scanning relative imports - properly ignoring in-app imports which were being reported as false positives.