Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Use math.radians() to compute default values in launch-files #284

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

[ros2] Use math.radians() to compute default values in launch-files #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions launch/bringup.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,17 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
is the prefix for the urdf description. -->
<arg name="tf_prefix" default="laser_1" />

<!-- Start angle of measurement in radian
https://github.com/ros2/launch/pull/557 would allow "$(eval math.radians(-137.4))"-->
<arg name="angle_start" default="-2.398082392240209" />
<!-- Start angle of measurement in radian -->
<arg name="angle_start" default="$(eval 'radians(-137.4)')" />

<!-- End angle of measurement in radian -->
<arg name="angle_end" default="2.398082392240209" />
<arg name="angle_end" default="$(eval 'radians(137.4)')" />

<!-- Publishing of intensities -->
<arg name="intensities" default="false" />

<!-- Scan resolution in radian -->
<arg name="resolution" default="0.0017453292519943296" />
<arg name="resolution" default="$(eval 'radians(0.1)')" />

<!-- IP-Address of host machine -->
<arg name="host_ip" default="auto" />
Expand Down
6 changes: 3 additions & 3 deletions launch/psen_scan_v2.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
<arg name="tf_prefix" default="laser_1" />

<!-- Start angle of measurement in radian -->
<arg name="angle_start" default="-2.398082392240209" />
<arg name="angle_start" default="$(eval 'radians(-137.4)')" />

<!-- End angle of measurement in radian -->

<arg name="angle_end" default="2.398082392240209" />
<arg name="angle_end" default="$(eval 'radians(137.4)')" />

<!-- Publishing of intensities -->
<arg name="intensities" default="false" />

<!-- Scan resolution in radian -->
<arg name="resolution" default="0.0017453292519943296" />
<arg name="resolution" default="$(eval 'radians(0.1)')" />

<!-- IP-Address of host machine -->
<arg name="host_ip" default="auto" />
Expand Down