Skip to content

Recording MVP (WIP) #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Recording MVP (WIP) #2183

wants to merge 14 commits into from

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Nov 7, 2025

Description

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • This PR has been linted.
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner November 7, 2025 04:34
@samfreund samfreund marked this pull request as draft November 7, 2025 04:34
@github-actions github-actions bot added photonlib Things related to the PhotonVision library backend Things relating to photon-core and photon-server labels Nov 7, 2025
@samfreund samfreund force-pushed the record branch 8 times, most recently from 4ef6b0f to 54e8be5 Compare November 13, 2025 17:05
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Nov 13, 2025
@samfreund samfreund force-pushed the record branch 5 times, most recently from 6a29ac8 to eea849a Compare November 14, 2025 04:10
samfreund
samfreund commented Nov 14, 2025
View reviewed changes
photon-client/src/components/settings/RecordingsCard.vue Outdated
<tr v-for="camera in camerasWithRecordings" :key="camera.uniqueName">
<td>{{ camera.nickname }}</td>
<td>
<pv-select
Copy link
Member Author

@samfreund samfreund Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note pv-select might not be the best choice here, due to padding, but I'm too lazy to make it look pretty. Somebody else should though, that would be pretty cool.

@samfreund samfreund force-pushed the record branch 2 times, most recently from 0beb299 to 2acadf0 Compare November 14, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items photonlib Things related to the PhotonVision library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samfreund