Skip to content

Conversation

@mcm001
Copy link
Contributor

@mcm001 mcm001 commented Oct 20, 2025

Description

image

A wireshark dissector can be handy for quickly visualizing time sync messages. See the docs for how to use this!

Full disclosure -- this dissector was generated by Claude 4.5, and I spot-checked all the numbers for correctness. This seems like idiomatic Lua to me, but I don't know Lua at all. I don't see a nice QOL thing nobody else will use as being a tech debt concern.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@mcm001 mcm001 requested a review from a team as a code owner October 20, 2025 03:23
@github-actions github-actions bot added the documentation Anything relating to https://docs.photonvision.org label Oct 20, 2025
@Gold856
Copy link
Collaborator

Gold856 commented Oct 20, 2025

Maybe we should put the Lua file in devTools? It's also empty except for the mrcal converter, so it'd be nice to make a decision on what to do there.

@mcm001
Copy link
Contributor Author

mcm001 commented Oct 20, 2025

DevTools rather than shipping it with the website makes sense to me

@samfreund samfreund force-pushed the wireshark-dissector branch from ef6f80a to 99168a6 Compare October 23, 2025 17:30
@samfreund
Copy link
Member

DevTools rather than shipping it with the website makes sense to me

Can we get this moved into there and the docs updated? After that, I think it should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants